wiring/validate.py

1# Structural + rendered-output checks for the wiring set. Writes PU_Validation_Rev-A.md. Exit 1 on FAIL.2import json, os, re, sys, xml.etree.ElementTree as ET3sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))4import model, sheet as S5 6HERE = os.path.dirname(os.path.abspath(__file__))7results = []   # (check, status, detail)8def rec(check, status, detail=""): results.append((check, status, detail))9 10# ---- structural -------------------------------------------------------------------------------11ids = [c["id"] for c in model.CONNECTIONS] + [p[0] for p in model.POWER_LINKS] + [o[0] for o in model.OPEN_ITEMS]12dups = sorted({i for i in ids if ids.count(i) > 1})13rec("Unique connection / link / open-item IDs", "FAIL" if dups else "PASS", f"duplicates: {dups}" if dups else f"{len(ids)} IDs")14 15bad = []16for c in model.CONNECTIONS:17  for end in (c["frm"], c["to"]):18    eq, conn = end19    if eq not in model.EQUIPMENT: bad.append(f"{c['id']}: unknown equipment {eq}")20    elif conn not in ("—","GND","PACK−","shield","J4/J5/J6/J7 shells") and (eq,conn) not in model.CONNECTORS: bad.append(f"{c['id']}: unknown connector {eq}.{conn}")21rec("Every connection references existing equipment and connectors", "FAIL" if bad else "PASS", "; ".join(bad) or f"{len(model.CONNECTIONS)} connections")22 23sheet_nos = {n for n,_ in model.SHEETS}24bad = [f"{c['id']}→{s}" for c in model.CONNECTIONS for s in c["sheets"] if s not in sheet_nos]25rec("Connection sheet cross-references resolve", "FAIL" if bad else "PASS", "; ".join(bad) or "all resolve")26 27mezz = sum(p[2] for p in model.MEZZ_PINS)28rec("Mezzanine allocation totals 80 pins", "PASS" if mezz == 80 else "FAIL", f"{mezz} pins across {len(model.MEZZ_PINS)} groups")29 30conn_pins = model.CONNECTORS[("MB","J12")][2]31rec("Pack pinout matches J12 position count", "PASS" if len(model.PINOUTS["J12 Battery pack (MB) / J1 (PB)"]["pins"]) == conn_pins else "FAIL", f"{conn_pins} positions")32 33# ---- rendered SVG checks ------------------------------------------------------------------------34svgs = sorted(f for f in os.listdir(os.path.join(HERE,"sheets")) if f.endswith(".svg"))35expected = [f"{model.sheet_no(n)}.svg" for n,_ in model.SHEETS]36rec("Every sheet in the index exists as an SVG", "PASS" if svgs == expected else "FAIL", f"{len(svgs)} files; missing {sorted(set(expected)-set(svgs))}, extra {sorted(set(svgs)-set(expected))}")37 38def num(v):39  try: return float(v)40  except: return None41oob_total = 0; overlap_total = 0; per_sheet = []42id_presence_fail = []43for f in svgs:44  p = os.path.join(HERE,"sheets",f); root = ET.parse(p).getroot()45  ns = {"s":"http://www.w3.org/2000/svg"}46  oob = 047  for el in root.iter():48    tag = el.tag.split("}")[-1]49    if tag == "rect":50      x,y,w,h = (num(el.get(a)) for a in ("x","y","width","height"))51      if None in (x,y,w,h): continue52      if el.get("width") == "100%": continue53      if x < 0 or y < 0 or x+w > S.W+0.5 or y+h > S.H+0.5: oob += 154    elif tag == "line":55      for a in ("x1","x2"):56        v = num(el.get(a)); 57        if v is not None and (v < 0 or v > S.W+0.5): oob += 158      for a in ("y1","y2"):59        v = num(el.get(a)); 60        if v is not None and (v < 0 or v > S.H+0.5): oob += 161    elif tag == "text":62      x,y = num(el.get("x")), num(el.get("y"))63      if x is None or y is None or x < 0 or x > S.W or y < 0 or y > S.H: oob += 164  meta = json.load(open(os.path.join(HERE,"preview",f.replace(".svg",".meta.json"))))65  # text-overlap heuristic on estimated bboxes (ignores table cell text against its own row, which cannot overlap by construction)66  T = [t for t in meta["texts"] if t[5] not in ("BORDER",)]67  ov = []68  for i in range(len(T)):69    x0,y0,x1,y1,ta,la = T[i]70    for j in range(i+1, len(T)):71      u0,v0,u1,v1,tb,lb = T[j]72      if x0 < u1-1 and u0 < x1-1 and y0 < v1-1 and v0 < y1-1:73        ov.append((ta[:40], tb[:40]))74  fx0,fy0,fx1,fy1 = meta["frame"]75  outside_frame = [t[4][:40] for t in T if t[5] not in ("BORDER","TITLE") and (t[0] < fx0-1 or t[2] > fx1+1 or t[1] < fy0-1 or t[3] > fy1+1)]76  # every connection that claims this sheet must be mentioned by ID on it77  n = f.split("-")[-1].replace(".svg","")78  missing = [c["id"] for c in model.CONNECTIONS if n in c["sheets"] and c["id"] not in meta["ids"]]79  if missing: id_presence_fail.append(f"{f}: {missing}")80  per_sheet.append((f, oob, len(ov), ov[:12], outside_frame[:8]))81  oob_total += oob; overlap_total += len(ov)82 83rec("Geometry inside the sheet bounds (1587 × 1123)", "PASS" if oob_total == 0 else "FAIL", f"{oob_total} out-of-bounds primitives")84rec("Connection IDs appear on every sheet they are assigned to", "FAIL" if id_presence_fail else "PASS", "; ".join(id_presence_fail) or "all present")85rec("Estimated text-bbox overlaps (heuristic, 0.53 em advance)", "PASS" if overlap_total == 0 else "WARN", f"{overlap_total} candidate overlaps — see per-sheet list; confirmed visually on PNG previews")86of = sum(len(x[4]) for x in per_sheet)87rec("Annotation text inside the drawing frame", "PASS" if of == 0 else "FAIL", f"{of} texts outside the frame")88 89pngs = sorted(f for f in os.listdir(os.path.join(HERE,"preview")) if f.endswith(".png"))90rec("PNG preview rendered for every sheet (headless Chrome)", "PASS" if len(pngs) == len(svgs) else "FAIL", f"{len(pngs)} PNG / {len(svgs)} SVG")91pdf = os.path.join(HERE, "PU_Wiring-Set_Rev-A.pdf")92if os.path.exists(pdf):93  n = len(re.findall(rb"/Type\s*/Page[^s]", open(pdf,"rb").read()))94  rec("Combined PDF page count equals sheet count", "PASS" if n == len(svgs) else "FAIL", f"{n} pages / {len(svgs)} sheets, {os.path.getsize(pdf)//1024} kB")95else:96  rec("Combined PDF page count equals sheet count", "NOT RUN", "PDF not found — run render.mjs without arguments")97rec("Electrical rule check / netlist", "NOT APPLICABLE", "SVG diagrams carry no netlist; ERC belongs to the EVT schematic capture")98rec("Native CAD (DXF/DWG) export", "NOT RUN", "no CAD tool or ezdxf available in this environment; SVG is the editable source")99 100# ---- report -----------------------------------------------------------------------------------101lines = [f"# PoppyUp wiring set — validation report (Rev {model.REV}, {model.DATE})", "",102         f"Baseline {model.BASELINE}. Status **{model.STATUS}**. Generated by `wiring/validate.py` after `build.py` and `render.mjs`.", "",103         "| # | Check | Result | Detail |", "|---|---|---|---|"]104for i,(c,s,d) in enumerate(results, 1): lines.append(f"| {i} | {c} | **{s}** | {d} |")105lines += ["", "## Per-sheet render checks", "", "| Sheet | Out-of-bounds primitives | Text-overlap candidates | Examples |", "|---|---|---|---|"]106for f,oob,nov,ex,of in per_sheet:107  exs = "; ".join(f"“{a}” ↔ “{b}”" for a,b in ex) or "—"108  if of: exs += f"; outside frame: {of}"109  lines.append(f"| {f} | {oob} | {nov} | {exs} |")110lines += ["", "## Open items carried on PU-W-000", ""]111for oid,t,d,src in model.OPEN_ITEMS: lines.append(f"- **{oid} {t}** — {d} (docs {src})")112lines += ["", "Result key: PASS / FAIL / WARN / NOT RUN / NOT APPLICABLE. A WARN on the text-overlap heuristic is not a defect by itself; the PNG previews in `wiring/preview/` are the visual record."]113open(os.path.join(HERE, "PU_Validation_Rev-A.md"),"w").write("\n".join(lines)+"\n")114fails = [r for r in results if r[1] == "FAIL"]115print("\n".join(f"{s:15s} {c} — {d}" for c,s,d in results))116sys.exit(1 if fails else 0)